Fix bug in manual column move #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repro for this bug: 1. Enable manualColumnMove 2. Click on the move tab of a column, but don't drag it Expected: column is not moved Actual: column can be moved to an arbitrary location If this is the first time that move-column has been invoked since the table was initialized, the afterColumnMove callback is actually invoked with a newIndex parameter of undefined or NaN. The cause is that endCol is not initialized unless the move tab is dragged into a different cell. The simple fix is to always initialize endCol = startCol as soon as we start dragging.
|
+1 for this fix. |
|
This pull request will be included in 0.9.18. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repro for this bug:
Expected: column is not moved
Actual: column can be moved to an arbitrary location
If this is the first time that move-column has been invoked since the
table was initialized, the afterColumnMove callback is actually invoked
with a newIndex parameter of undefined or NaN.
The cause is that endCol is not initialized unless the move tab is
dragged into a different cell. The simple fix is to always initialize
endCol = startCol as soon as we start dragging.