Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

armv7? Not really #11

Closed
MagaTailor opened this issue Dec 28, 2015 · 7 comments
Closed

armv7? Not really #11

MagaTailor opened this issue Dec 28, 2015 · 7 comments
Assignees
Labels

Comments

@MagaTailor
Copy link

I've just noticed the armhf target's code generation was actually geared towards v6 for compatibility.

Seeing as you already provide separate armv6 builds it makes sense for the armv7 ones to generate code for v7, incl. at the time of bootstrapping themselves (curiously it's the default on android.)

Literally we're talking about just two commands before the start of the armv7 build:

sed -i s/v6/v7/ src/librustc_back/target/arm_unknown_linux_gnueabihf.rs

and

sed -i s/v6/v7/ mk/cfg/arm-unknown-linux-gnueabihf.mk

To try out the proposed changes anyone can use the scripts from my fork.

@warricksothr
Copy link
Owner

Good catch! I'll make the changes and kick off a test build tonight and see if I can run a resulting binary on my odroid.

@warricksothr warricksothr self-assigned this Jan 7, 2016
@MagaTailor
Copy link
Author

No worries, I never suggested adding +neon to the default set of features :)

@MagaTailor
Copy link
Author

Can we close it? There's probably going to be an official armv7 target anyway so you'll simply switch to that once it's available.

@warricksothr
Copy link
Owner

Sure, Any news on when that's going to be added as a target?

@MagaTailor
Copy link
Author

Not clear yet, but you could add your two cents in that open Rpi PR.

@MagaTailor
Copy link
Author

It's done, the new target is called:

armv7-unknown-linux-gnueabihf

However switching to it will require a rebuild of the last stage0 snapshot first, after adding the new target to the list.

@warricksothr
Copy link
Owner

Good to know. I'll try to get a snapshot built.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants