-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add avatar component + storybook example #122
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1d06445:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add examples to the server side testing page in the app? https://wpds-ui-kit-git-feature-create-avatar-component.preview.now.washingtonpost.com/. This helps us catch possible server side render issues with our components.
Also your PR title and commit messages should be updated to say "feat: add avatar component + storybook example". See here for spec https://www.conventionalcommits.org/en/v1.0.0/#summary |
e0e0e23
to
ea8cd6f
Compare
oof looks like we got conflicts and some checks failing |
…onpost/wpds-ui-kit into feature/create-avatar-component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All set 🚀
What I did
Displays avatar components on sandbox
When image is loading/not able to render