Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add avatar component + storybook example #122

Merged
merged 23 commits into from
Jun 24, 2022

Conversation

atomictangerine
Copy link
Contributor

@atomictangerine atomictangerine commented Jun 13, 2022

What I did

  • Migrates the avatar component.
  • Adds storybook example
  • Creates chromatic baseline
  • Updates README
  • Adds avatar to the Server Side Testing app page

Screen Shot 2022-06-13 at 9 17 03 PM

Displays avatar components on sandbox

Screen Shot 2022-06-14 at 2 26 30 PM

When image is loading/not able to render

Screen Shot 2022-06-14 at 2 18 39 PM

@vercel
Copy link

vercel bot commented Jun 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
wpds-ui-kit ✅ Ready (Inspect) Visit Preview Jun 24, 2022 at 5:13PM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 13, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1d06445:

Sandbox Source
React Configuration
@washingtonpost/wpds-test-app Configuration

app/next.config.js Outdated Show resolved Hide resolved
ui/avatar/package.json Outdated Show resolved Hide resolved
ui/avatar/src/Avatar.tsx Outdated Show resolved Hide resolved
ui/avatar/src/Avatar.tsx Outdated Show resolved Hide resolved
ui/avatar/src/Avatar.tsx Outdated Show resolved Hide resolved
ui/kit/package.json Outdated Show resolved Hide resolved
ui/kit/package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@artmsilva artmsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add examples to the server side testing page in the app? https://wpds-ui-kit-git-feature-create-avatar-component.preview.now.washingtonpost.com/. This helps us catch possible server side render issues with our components.

@artmsilva
Copy link
Contributor

Also your PR title and commit messages should be updated to say "feat: add avatar component + storybook example". See here for spec https://www.conventionalcommits.org/en/v1.0.0/#summary

@atomictangerine atomictangerine force-pushed the feature/create-avatar-component branch from e0e0e23 to ea8cd6f Compare June 14, 2022 04:09
@atomictangerine atomictangerine changed the title feature: add avatar component + storybook example feat: add avatar component + storybook example Jun 14, 2022
ui/avatar/package.json Outdated Show resolved Hide resolved
app/next.config.js Outdated Show resolved Hide resolved
@artmsilva
Copy link
Contributor

oof looks like we got conflicts and some checks failing

ui/avatar/src/Avatar.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@wp-aberg wp-aberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All set 🚀

@atomictangerine atomictangerine merged commit 6e30047 into main Jun 24, 2022
@atomictangerine atomictangerine deleted the feature/create-avatar-component branch June 24, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants