-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tabs component [SRED-67] #340
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -17,7 +17,7 @@ | |||
"@storybook/jest": "^0.0.10", | |||
"@storybook/manager-webpack5": "^6.5.16", | |||
"@storybook/react": "^6.5.16", | |||
"@storybook/test-runner": "^0.9.4", | |||
"@storybook/test-runner": "^0.6.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bumping down because versions higher than this use jest28 and that causes a globalSetup error with storybook jest
@@ -129,7 +129,7 @@ | |||
"./ui" | |||
], | |||
"preset": "ts-jest", | |||
"testEnvironment": "jsdom", | |||
"testEnvironment": "./custom-env.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using a custom environment to add DOMRect mocks to the jest environment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work!!
What I did