Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tabs component [SRED-67] #340

Merged
merged 30 commits into from
Mar 17, 2023
Merged

feat: tabs component [SRED-67] #340

merged 30 commits into from
Mar 17, 2023

Conversation

atomictangerine
Copy link
Contributor

@atomictangerine atomictangerine commented Mar 3, 2023

What I did

  • Add tabs component
  • Add tabs docs
  • Add tabs jest tests
  • Add storybook examples
  • Add storybook interaction tests
  • Add custom jest environment for global mocking of DOMRect
  • Add reduced motion support for tabs

@atomictangerine atomictangerine self-assigned this Mar 3, 2023
@vercel
Copy link

vercel bot commented Mar 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
wpds-ui-kit ✅ Ready (Inspect) Visit Preview 1 resolved Mar 17, 2023 at 3:46PM (UTC)
wpds-ui-kit-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 17, 2023 at 3:46PM (UTC)
wpds-ui-kit-vitejs-example ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 17, 2023 at 3:46PM (UTC)
wpds-ui-kit-vitejs-v2-example ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 17, 2023 at 3:46PM (UTC)

@@ -17,7 +17,7 @@
"@storybook/jest": "^0.0.10",
"@storybook/manager-webpack5": "^6.5.16",
"@storybook/react": "^6.5.16",
"@storybook/test-runner": "^0.9.4",
"@storybook/test-runner": "^0.6.4",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bumping down because versions higher than this use jest28 and that causes a globalSetup error with storybook jest

@@ -129,7 +129,7 @@
"./ui"
],
"preset": "ts-jest",
"testEnvironment": "jsdom",
"testEnvironment": "./custom-env.ts",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using a custom environment to add DOMRect mocks to the jest environment

Copy link
Contributor

@artmsilva artmsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants