Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additional host configuration options for images, policy #31

Merged
merged 1 commit into from
May 9, 2024

Conversation

protochron
Copy link
Contributor

Feature or Problem

Add additional host options for the policy service, allowing insecure registries and pulling the latest tag of an OCI ref.

Related Issues

Release Information

next

Consumer Impact

Testing

Tested locally in a kind cluster

Unit Test(s)

Acceptance or Integration

Manual Verification

@protochron protochron requested a review from joonas May 7, 2024 01:12
Copy link

github-actions bot commented May 7, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@protochron protochron force-pushed the policy_service_config branch 2 times, most recently from 4058bcc to 272bbf0 Compare May 7, 2024 01:16
Copy link
Member

@joonas joonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentatively LGTM, we should switch from subject to topic on the two NATS policy subjects to match the the wasmCloud host flag naming.

Add additional host options for the policy service, allowing insecure
registries and pulling the latest tag of an OCI ref.

Signed-off-by: Dan Norris <protochron@users.noreply.github.com>
@protochron protochron merged commit 77b8c86 into main May 9, 2024
5 checks passed
@protochron protochron deleted the policy_service_config branch May 9, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants