fix: allow nats address to include a port #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
This fix omits the preset NATS leaf node port `7422` from being automatically set if the `natsAddress` field is set in the CRD. This allows you to specify the port if it is not using the default at the cost of making it required. Signed-off-by: Dan Norris <protochron@users.noreply.github.com>
joonas
approved these changes
May 27, 2024
ricochet
approved these changes
May 28, 2024
protochron
added a commit
that referenced
this pull request
May 28, 2024
PR #35 introduced a small regression which only impacts clients who are trying to use nonstandard ports. This fixes the problem by allowing the NATS leaf node and client ports to be configured separately in the CRD.
protochron
added a commit
that referenced
this pull request
May 28, 2024
PR #35 introduced a small regression which only impacts clients who are trying to use nonstandard ports. This fixes the problem by allowing the NATS leaf node and client ports to be configured separately in the CRD. Signed-off-by: Dan Norris <protochron@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This fix omits the preset NATS leaf node port
7422from being automatically set if thenatsAddressfield is set in the CRD. This allows you to specify the port if it is not using the default at the cost of making it required.Related Issues
Release Information
next
Consumer Impact
Testing
Tested locally with kind connected to a NATS cluster serving leaf node connections on a different port than the default