fix: add options for setting NATS leaf and client ports separately #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #35 introduced a small regression which only impacts clients who are trying to use nonstandard ports. This fixes the problem by allowing the NATS leaf node and client ports to be configured separately in the CRD. Signed-off-by: Dan Norris <protochron@users.noreply.github.com>
protochron
force-pushed
the
fix_nats_ports
branch
from
ec1d795
to
6df71d1
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
joonas
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
PR #35 introduced a small regression which only impacts clients who are trying to use nonstandard ports. This fixes the problem by allowing the NATS leaf node and client ports to be configured separately in the CRD.
Related Issues
Release Information
next
Consumer Impact
Testing
Works locally in kind
Unit Test(s)
Acceptance or Integration
Manual Verification