-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update Example Setup #70
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxfontes
force-pushed
the
lxfontes/refactor-example
branch
2 times, most recently
from
July 10, 2024 16:53
2135db0
to
ca54a67
Compare
joonas
reviewed
Jul 10, 2024
protochron
approved these changes
Jul 10, 2024
protochron
reviewed
Jul 10, 2024
Signed-off-by: Lucas Fontes <lucas@cosmonic.com>
Signed-off-by: Lucas Fontes <lucas@cosmonic.com>
Signed-off-by: Lucas Fontes <lucas@cosmonic.com>
Signed-off-by: Lucas Fontes <lucas@cosmonic.com>
It might be nice to also update the wasmcloud.com docs (source) to reflect these updates if you wouldn't mind opening a similar PR over there as well |
Signed-off-by: Lucas Fontes <lucas@cosmonic.com>
lxfontes
force-pushed
the
lxfontes/refactor-example
branch
from
July 22, 2024 15:39
a80a085
to
a5f3aeb
Compare
@joonas this is ready for another pass! |
joonas
reviewed
Jul 22, 2024
joonas
reviewed
Jul 22, 2024
Signed-off-by: Lucas Fontes <lucas@cosmonic.com>
joonas
reviewed
Jul 22, 2024
joonas
reviewed
Jul 22, 2024
joonas
reviewed
Jul 22, 2024
joonas
reviewed
Jul 22, 2024
Signed-off-by: Lucas Fontes <lucas@cosmonic.com>
joonas
reviewed
Jul 22, 2024
joonas
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Co-authored-by: Joonas Bergius <joonas@users.noreply.github.com> Signed-off-by: Lucas Fontes <lxfontes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganizing examples into a directory structure, starting with a quickstart.