Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporary patch for Wasmer #312

Closed
Michael-F-Bryan opened this issue Dec 1, 2022 · 1 comment
Closed

Remove temporary patch for Wasmer #312

Michael-F-Bryan opened this issue Dec 1, 2022 · 1 comment
Assignees

Comments

@Michael-F-Bryan
Copy link
Contributor

Michael-F-Bryan commented Dec 1, 2022

In #310, we patched our wasmer dependency so we could use the fix from wasmerio/wasmer#3400 and publish it to NPM.

wasmer-js/Cargo.toml

Lines 25 to 30 in 96a846e

# TODO(Michael-F-Bryan): Remove this when Wasmer 3.1 comes out
# See https://github.com/wasmerio/wasmer-js/issues/312 for more.
[patch.crates-io]
wasmer = { git = "https://github.com/wasmerio/wasmer", default-features = false, features = ["js", "std"], rev = "ecde2aa" }
wasmer-wasi = { git = "https://github.com/wasmerio/wasmer", default-features = false, features = ["js"], rev = "ecde2aa" }
wasmer-vfs = { git = "https://github.com/wasmerio/wasmer", default-features = false, features = ["mem-fs"], rev = "ecde2aa" }

When Wasmer 3.1 comes out, we'll need to remove the patch and switch back to wasmer from crates.io.

@Michael-F-Bryan Michael-F-Bryan self-assigned this Dec 1, 2022
@Michael-F-Bryan
Copy link
Contributor Author

No longer necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant