abortOnCannotGrowMemory has the wrong type signiture, _emscripten_get_heap_size and _emscripten_resize_heap missing

[davidMcneil]

I am trying to compile and run the emscripten tests (make emtests). I try and run an output wasm file for example clock_gettime.wasm and get the following error:

"Can\'t instantiate module: LinkError([ImportNotFound { namespace: \"env\", name: \"_emscripten_get_heap_size\" }, ImportNotFound { namespace: \"env\", name: \"_emscripten_resize_heap\" }, IncorrectImportSignature { namespace: \"env\", name: \"abortOnCannotGrowMemory\", expected: FuncSig { params: [I32], returns: [I32] }, found: FuncSig { params: [], returns: [I32] } }])"

Comparing the resulting wasm files it looks like the type for abortOnCannotGrowMemory has changed from:
(type $t2 (func (result i32)))
to
(type $t1 (func (param i32) (result i32)))

It also looks like _emscripten_get_heap_size and _emscripten_resize_heap are missing. These are not even imported in the original wasm.

It seems like this may be an issue with emscripten and not wasmer. I am using emscripten version 1.38.26.

[syrusakbary]

Taking a look now.
It seems memory management changed a bit: emscripten-core/emscripten@1655d72

I think is feasible to support both cases (old-emscripten files, and new ones)

[davidMcneil]

Compiling with emscripten version 1.38.21 fixes the issue.

[davidMcneil]

This is by no means a complete solution, but it gets the tests to pass https://github.com/davidMcneil/wasmer/tree/172. I would be happy to put this into a more formal pull request. What would be the best way to determine the type signature of abortOnCannotGrowMemory to use?

[syrusakbary]

Thanks for the changes @davidMcneil.

I've created the PR #173 to add a comment to have compatibility for both functions:
#173

(any change in your branch will be reflected in the PR)

[syrusakbary]

Closing the issue, as is fixed with #173