Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve how mapdir works (proposal) #4182

Closed
syrusakbary opened this issue Aug 25, 2023 · 2 comments · May be fixed by #4298
Closed

Improve how mapdir works (proposal) #4182

syrusakbary opened this issue Aug 25, 2023 · 2 comments · May be fixed by #4298
Labels
📦 lib-cli About wasmer-cli 📦 lib-wasi About wasmer-wasi priority-low Low priority issue 🏚 stale Inactive issues or PR
Milestone
backlog

Comments

@syrusakbary
Copy link
Member

syrusakbary commented Aug 25, 2023 •
edited
Loading

Currently, mapping into . in the host is problematic, because... what is .: is it / or is it other dir?

My thoughts on how to resolve this, to minimize collisions with root:

  • set /home as the current working directory by default
  • Anything mounted on . will be mounted on /home. For example: wasmer run myprogram --dir=. would be equivalent to wasmer run myprogram --mapdir=.:. which will be equivalent to wasmer run --mapdir=.:/home

That will resolve multiple issues that we have in the filesystem, like mounting . in / and many more
@syrusakbary syrusakbary added this to the v4.2 milestone Aug 25, 2023
@Michael-F-Bryan Michael-F-Bryan added 📦 lib-wasi About wasmer-wasi 📦 lib-cli About wasmer-cli priority-low Low priority issue labels Aug 29, 2023
@Michael-F-Bryan Michael-F-Bryan modified the milestones: v4.2, v4.3 Aug 29, 2023
@syrusakbary syrusakbary mentioned this issue Nov 10, 2023
Open
11 tasks
@stale Stale
Copy link

stale bot commented Sep 4, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 🏚 stale Inactive issues or PR label Sep 4, 2024
@stale Stale
Copy link

stale bot commented Oct 19, 2024

Feel free to reopen the issue if it has been closed by mistake.

@stale stale bot closed this as completed Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📦 lib-cli About wasmer-cli 📦 lib-wasi About wasmer-wasi priority-low Low priority issue 🏚 stale Inactive issues or PR
Projects
None yet
Milestone
backlog
Development

Successfully merging a pull request may close this issue.

Virtual fs refactor wasmerio/wasmer
2 participants
@syrusakbary @Michael-F-Bryan