-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows support #51
Comments
Agreed! Supporting Windows will be a big win for a cross-platform runtime, which is in our goals. Here are the things that we will need to do in order to have Windows support:
We will post here the updates once we start working on it. |
It is a shame that wabt-rs doesn't work for Windows. Would love to help, but I don't have much experience with Windows nor have I a windows machine. |
@syrusakbary that’s all great news! I’ve already started the ball rolling with @pepyakin on windows support. I’m also investigating signal support in libc for windows. Seems doable. |
I think I have spent the last few hours getting familiar with the details of stdio capture on windows. I think this is possible with just |
@syrusakbary I think I have a solution for capturing the stdio, but I can't help feel that capturing stdio in-process seems a little round-about. A problem is windows pipes don't seem to be buffered and that has made it a bit more compilcated. The WinAPI has buffered pipes, but it would be a completely different implementation from the How about storing the tests in a test executable crate and spawning it from integration tests? The standard output can be captured with normal safe rust. There is no platform specific code or unsafe code. I can't imagine the performance is any worse. Thoughts? |
That's something we considered on doing before. However, we discared it because of:
We can use two different implementations, one for *nix systems and other for Windows. It might be easier to achieve? Ideally, I lean towards the second option since it makes the testing and debugging easier. Thoughts? |
We added experimental Windows, so it can now run WebAssembly files. There is still some work to do regarding Emscripten (#176) but other than that everything is tested and green 🎉. We are preparing for Wasmer 0.2.0 and will close this issue once we publish the wasmer.exe file :) |
Okay, so I was able to test it today and it seems like it does work for the most part. However there is something that seems to be broken. In my wasm file I have an exported function that returns a f64 value and that does not seem to be returned correctly by wasmer. I'm getting some garbage value on the host side. I'm not sure if that's just a windows abi mismatch or if this affects Linux and co. as well. |
@CryZe I am glad you're able to try it out! Could you post an issue that reproduces your problem? |
Yeah I'll open a full issue with a reproducible example (and maybe tested on Linux too) in a bit. |
We just published Wasmer 0.2.0 -> https://github.com/wasmerio/wasmer/releases/tag/0.2.0 We created a separate issue to implement the emscripten syscalls in Windows #176. Here's a useful PR that updates the wasmer-rust-example to the new 0.2.0 API. Closing the issue :) |
There seem to be a few barriers to windows support. There is an outstanding bug on
wabt-rs
that prevents building on windows. There is a hacky work around, but non-ideal.The codebase also seems to import many linux-only libraries, so those would have to refactored or conditionally compiled.
Windows support would be a big win for portability, which I imagine is a priority for a tool that aims to be a cross-platform wasm runtime.
The text was updated successfully, but these errors were encountered: