Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add many emscripten functions for PHP #285

Merged
merged 10 commits into from
Mar 25, 2019
Merged

add many emscripten functions for PHP #285

merged 10 commits into from
Mar 25, 2019

Conversation

MarkMcCaskey
Copy link
Contributor

No description provided.

@MarkMcCaskey MarkMcCaskey marked this pull request as ready for review March 22, 2019 18:23
xmclark
xmclark approved these changes Mar 25, 2019
View reviewed changes
lib/emscripten/src/io/unix.rs Outdated
0
}

// REVIEW: does this belong here?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The location is fine. We can always move it later.

lib/emscripten/src/syscalls/unix.rs
#[allow(clippy::cast_ptr_alignment)]
let rusage = emscripten_memory_pointer!(ctx.memory(0), rusage_ptr) as *mut rusage;
// REVIEW: is this the correct way to verify alignment?
assert_eq!(8, mem::align_of_val(&rusage));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this is fine

@MarkMcCaskey
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Mar 25, 2019
@bors @MarkMcCaskey
Merge #285
1a94ad1 
285: add many emscripten functions for PHP r=MarkMcCaskey a=MarkMcCaskey



Co-authored-by: Mark McCaskey <mark@wasmer.io>
Co-authored-by: Mark McCaskey <markmccaskey@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Mar 25, 2019

Build failed

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Mar 25, 2019
@bors
Try #285:
df8fbf3
@MarkMcCaskey
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Mar 25, 2019
@bors @MarkMcCaskey
Merge #285
0e632ca 
285: add many emscripten functions for PHP r=MarkMcCaskey a=MarkMcCaskey



Co-authored-by: Mark McCaskey <mark@wasmer.io>
Co-authored-by: Mark McCaskey <markmccaskey@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Mar 25, 2019

try

Build succeeded

@bors
Copy link
Contributor

bors bot commented Mar 25, 2019

Build succeeded

@bors bors bot merged commit d825746 into master Mar 25, 2019
@bors bors bot deleted the feature/add-syscalls-for-php branch March 25, 2019 18:09
surban pushed a commit to rust-wasi-web/wwrr that referenced this pull request Nov 9, 2024
@syrusakbary
Merge pull request wasmerio#285 from wasmerio/public-instance
17c4ff3 
Return the raw instance when instantiating. Fix wasmerio#284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmclark xmclark xmclark approved these changes

Assignees
No one assigned
Labels
📦 lib-emscripten About wasmer-emscripten
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkMcCaskey @xmclark