feat(runtime-c-api) Implement the wasmer_export_to_memory function
#296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new function returns a `wasmer_memory_t` from a `wasmer_export_t`.
Hywan
added
🎉 enhancement
bjfish
approved these changes
Mar 27, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 27, 2019
296: feat(runtime-c-api) Implement the `wasmer_export_to_memory` function r=Hywan a=Hywan This new function returns a `wasmer_memory_t` from a `wasmer_export_t`. It allows to use the `wasmer_memory_*` API over the exported memories from a Wasm instance. See `tests/assets/return_hello.rs` and `tests/test-exported-memory.c` for an end-to-end example. This PR also moves all `tests/.wasm` files into `tests/assets/`. I've added the source of `return_hello.wasm` to be exhaustive and to serve as a documentation. Co-authored-by: Ivan Enderlin <ivan.enderlin@hoa-project.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new function returns a
wasmer_memory_tfrom awasmer_export_t. It allows to use thewasmer_memory_*API over the exported memories from a Wasm instance.See
tests/assets/return_hello.rsandtests/test-exported-memory.cfor an end-to-end example.This PR also moves all
tests/.wasmfiles intotests/assets/. I've added the source ofreturn_hello.wasmto be exhaustive and to serve as a documentation.