feat(runtime-c-api) Split the big lib.rs file into modules
#312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjfish
approved these changes
Mar 29, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 29, 2019
312: feat(runtime-c-api) Split the big `lib.rs` file into modules r=Hywan a=Hywan This PR splits the `lib.rs` file into smaller modules. Proof everything is OK: 1. `wasmer.h` and `wasmer.hh` are not different, 2. Tests are still green, 3. `rustc` is polite. Bonus: I removed the last couple of warnings. Next step: Add more documentations. Co-authored-by: Ivan Enderlin <ivan.enderlin@hoa-project.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the
lib.rsfile into smaller modules.Proof everything is OK:
wasmer.handwasmer.hhare not different,rustcis polite.Bonus: I removed the last couple of warnings.
Next step: Add more documentations.