Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Js imports revamp #3138

Merged
merged 6 commits into from
Aug 30, 2022
Merged

Js imports revamp #3138

merged 6 commits into from
Aug 30, 2022

Conversation

syrusakbary
Copy link
Member

This PR removes the JsImportObject in favor of adding a new_from_js_object method to the Imports

@syrusakbary syrusakbary mentioned this pull request Aug 30, 2022
Merged
3 tasks
@syrusakbary
Copy link
Member Author

Merging this manually, as tests already passed

@syrusakbary syrusakbary merged commit dafdd94 into master Aug 30, 2022
@bors bors bot deleted the js-imports-revamp branch August 30, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@syrusakbary