Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat enhanced tinytunable test #3178

Merged
merged 15 commits into from
Oct 10, 2022
Merged

Conversation

ptitSeb
Copy link
Contributor

@ptitSeb ptitSeb commented Sep 8, 2022

Description

Added a new test for Custom Tunables, with a Store and Instance creation.

@ptitSeb ptitSeb requested a review from syrusakbary as a code owner September 8, 2022 10:15
@syrusakbary syrusakbary added this to the v3.0 milestone Oct 5, 2022
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small minor nit, but looks great overall!

lib/vm/src/memory.rs Outdated Show resolved Hide resolved
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested a small change, sorry for the double re-review

@ptitSeb ptitSeb requested a review from syrusakbary October 6, 2022 07:52
@syrusakbary syrusakbary merged commit 06300d3 into master Oct 10, 2022
@bors bors bot deleted the feat_enhanced_tinytunable_test branch October 10, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants