Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seal HostFunctionKind #3218

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Seal HostFunctionKind #3218

merged 1 commit into from
Oct 5, 2022

Conversation

uint
Copy link
Contributor

@uint uint commented Oct 5, 2022 •
edited
Loading

Description

I noticed the HostFunctionKind trait was clearly intended to be sealed, but it actually isn't. This PR completes the sealing pattern. Feels like this is important to include in the 3.0.0 release to avoid subtle breaking changes. This PR is itself a breaking change.

Review

  • Add a short description of the change to the CHANGELOG.md file

@uint uint requested a review from syrusakbary as a code owner October 5, 2022 09:35
syrusakbary
syrusakbary approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great call! Merging

@syrusakbary syrusakbary merged commit 07c2add into wasmerio:master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uint @syrusakbary