Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filesystem rights on WASI, add integration test for file permissions #3240

Merged
merged 23 commits into from
Oct 25, 2022
Merged

Fix filesystem rights on WASI, add integration test for file permissions #3240

merged 23 commits into from
Oct 25, 2022

Conversation

fschutt
Copy link
Contributor

@fschutt fschutt commented Oct 19, 2022

Fixes #3125

@fschutt fschutt requested a review from syrusakbary October 19, 2022 16:46
@fschutt fschutt mentioned this pull request Oct 19, 2022
Closed
Michael-F-Bryan
Michael-F-Bryan reviewed Oct 24, 2022
View reviewed changes
Copy link
Contributor

@Michael-F-Bryan Michael-F-Bryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to follow up on the failing fd_append tests. I feel like they could be legitimate test failures, although I'm curious why it only shows on nightly and not the test suites for older compilers.

lib/vfs/src/lib.rs Outdated Show resolved Hide resolved
lib/vfs/src/lib.rs Show resolved Hide resolved
tests/ignores.txt Outdated Show resolved Hide resolved
@fschutt fschutt mentioned this pull request Oct 24, 2022
Open
@fschutt
Copy link
Contributor Author

fschutt commented Oct 24, 2022

@syrusakbary This should pass now. I have disabled the fd_append and path_symlink tests because they failed even before I changed any code, but only on nightly. Meaning the bug is somewhere in the diff between stable and nightly, not because of my code as explained by my comment here:

https://github.com/wasmerio/wasmer/actions/runs/3290950297/jobs/5424476629#step:18:415

I think this can be merged, but I've opened #3250 for tracking this "regression".

@Michael-F-Bryan
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 25, 2022

Build succeeded:

@bors bors bot merged commit 8357176 into master Oct 25, 2022
@bors bors bot deleted the wasi-fs-rights-2 branch October 25, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michael-F-Bryan Michael-F-Bryan Michael-F-Bryan left review comments

@syrusakbary syrusakbary syrusakbary left review comments

@ptitSeb ptitSeb ptitSeb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WASI: file system rights doesn't work
4 participants
@fschutt @Michael-F-Bryan @syrusakbary @ptitSeb