-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return ENotCapable error when accessing unknown files on root (for #3263 and #3264) #3266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add also a test
This is a challenge here: the original tests are based on C code and around specific syscall error code return or Exit Code value. There is no infrastructure to do that on wasmer tests With a mapdir test_fs run #include <assert.h>
#include <errno.h>
#include <stdio.h>
int main() {
FILE* file = fopen("test_fs.not/..", "r");
assert(file == NULL);
assert(errno == ENOTCAPABLE);
return 0;
} or simply run #include <stdlib.h>
int main(void) {
abort();
return 0;
} And check that the exit code is 134 ( |
bors r+ |
Build succeeded: |
Fixes for wasm.fyi tests: