Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes to make PHP run better #329

Merged
merged 2 commits into from
Apr 5, 2019
Merged

changes to make PHP run better #329

merged 2 commits into from
Apr 5, 2019

Conversation

MarkMcCaskey
Copy link
Contributor

Fixes:

  • memory access when ending programs (by implementing TempRet0
  • munmap errors from PHP by lying and just returning 0

@MarkMcCaskey MarkMcCaskey added the 📦 lib-emscripten About wasmer-emscripten label Apr 5, 2019
@MarkMcCaskey
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Apr 5, 2019
@bors
Merge #329
1c2f0e9 
329: changes to make PHP run better r=MarkMcCaskey a=MarkMcCaskey

Fixes:
- memory access when ending programs (by implementing `TempRet0`
- `munmap` errors from PHP by lying and just returning 0

Co-authored-by: Mark McCaskey <mark@wasmer.io>
@bors
Copy link
Contributor

bors bot commented Apr 5, 2019

Build succeeded

@bors bors bot merged commit 516b932 into master Apr 5, 2019
@bors bors bot deleted the feature/changes-for-php branch April 5, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
📦 lib-emscripten About wasmer-emscripten
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkMcCaskey @syrusakbary