Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement wasmer init and wasmer publish #3324

Merged
merged 91 commits into from
Dec 16, 2022
Merged

Implement wasmer init and wasmer publish #3324

merged 91 commits into from
Dec 16, 2022

Conversation

fschutt
Copy link
Contributor

@fschutt fschutt commented Nov 18, 2022

No description provided.

@fschutt fschutt requested a review from syrusakbary as a code owner November 18, 2022 12:54
@fschutt fschutt changed the title Add wasmer init Implement wasmer init Nov 18, 2022
Michael-F-Bryan
Michael-F-Bryan suggested changes Nov 21, 2022
View reviewed changes
lib/cli/src/commands/init.rs Outdated Show resolved Hide resolved
lib/cli/src/commands/init.rs Outdated Show resolved Hide resolved
lib/cli/src/commands/init.rs Outdated Show resolved Hide resolved
Michael-F-Bryan
Michael-F-Bryan approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@Michael-F-Bryan Michael-F-Bryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've got the core of wasmer init here. Let's merge it once CI passes and make a follow-up PR refactoring Init::execute().

@ptitSeb ptitSeb added this to the v3.1 milestone Nov 30, 2022
@fschutt fschutt mentioned this pull request Dec 2, 2022
Closed
@fschutt fschutt modified the milestones: v3.1, v3.2 Dec 6, 2022
@fschutt fschutt changed the title Implement wasmer init Implement wasmer init and wasmer publish Dec 12, 2022
fschutt added 21 commits December 12, 2022 14:33
@fschutt
Add wasmer init
0dfa9a8
@fschutt
Fix wapm.toml definition
41a311d
@fschutt
Detect cargo wapm and add metadata to Cargo.toml, if applicable
e2126b5
@fschutt
Fix make lint
248b2f2
@fschutt
Fix wapm init compilation
73c6387
@fschutt
wasmer init: migrate to cargo_metadata
a29cc7d
@fschutt
Correctly recognize .wai bindings
507b4f1
@fschutt
cargo fmt
bb3de1f
@fschutt
cargo update
83a4334
@fschutt
Update wapm toml version
e69ea73
@fschutt
Update wapm-toml version again
53a08b4
@fschutt
Refactor wasmer init with comments
c4e1422
@fschutt
Fix make lint
7ba13bc
@fschutt
Add integration tests for wasmer init
b8d1d4e
@fschutt
Fix second integration test for wasmer init
1c754a0
@fschutt
Fix relative path in source of module
ac9d392
@fschutt
Add flow test for wasmer init + cargo wapm publish
2b09fc4
@fschutt
Use current logged in user as namespace in wasmer init
c325ce6
@fschutt
Add debugging to integration test
3eaa585
@fschutt
Update wapm version in Makefile
6ac97af
@fschutt
Install wapm before running integration tests
9a4d21b
@fschutt
Copy link
Contributor Author

fschutt commented Dec 16, 2022

@Michael-F-Bryan okay, this should be done now, I removed support for cargo wapm, so those problems with namespace = ... are gone now.

ptitSeb
ptitSeb reviewed Dec 16, 2022
View reviewed changes
lib/cli/Cargo.toml Outdated Show resolved Hide resolved
ptitSeb
ptitSeb reviewed Dec 16, 2022
View reviewed changes
rust-toolchain Outdated Show resolved Hide resolved
@fschutt
Copy link
Contributor Author

fschutt commented Dec 16, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 16, 2022

👎 Rejected by code reviews

@fschutt
Copy link
Contributor Author

fschutt commented Dec 16, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 16, 2022

Build succeeded:

@bors bors bot merged commit 7a90abf into master Dec 16, 2022
@bors bors bot deleted the init branch December 16, 2022 21:02
@syrusakbary syrusakbary restored the init branch December 16, 2022 22:05
@syrusakbary syrusakbary mentioned this pull request Dec 16, 2022
Merged
syrusakbary
syrusakbary reviewed Dec 16, 2022
View reviewed changes
Makefile Show resolved Hide resolved
syrusakbary
syrusakbary reviewed Dec 16, 2022
View reviewed changes
lib/cli/src/commands/init.rs
let toml_string = toml::to_string_pretty(&toml)?
.replace(
"[dependencies]",
&format!("{NOTE}{NEWLINE}{NEWLINE}[dependencies]"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good touch

@fschutt fschutt mentioned this pull request Dec 16, 2022
Merged
This was referenced Jan 17, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michael-F-Bryan Michael-F-Bryan Michael-F-Bryan left review comments

@theduke theduke theduke left review comments

@syrusakbary syrusakbary syrusakbary left review comments

@ptitSeb ptitSeb ptitSeb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2
Development

Successfully merging this pull request may close these issues.
5 participants
@fschutt @Michael-F-Bryan @syrusakbary @theduke @ptitSeb