Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the actual LZCNT / TZCNT implementation #3364

Merged
merged 4 commits into from
Nov 24, 2022
Merged

Added the actual LZCNT / TZCNT implementation #3364

merged 4 commits into from
Nov 24, 2022

Conversation

ptitSeb
Copy link
Contributor

@ptitSeb ptitSeb commented Nov 23, 2022

Description

The actual implementation of LZCNT and TZCNT for the x86_64 Singlepass backend.
Somehow, it was missing from #3302

@ptitSeb ptitSeb requested a review from syrusakbary as a code owner November 23, 2022 12:05
@ptitSeb ptitSeb requested a review from theduke November 23, 2022 12:05
theduke
theduke reviewed Nov 23, 2022
View reviewed changes
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General question: do we have codegen test suites that validate behaviour both with and without certain flags?

That would be a huge surface area to test though, so probably not?

lib/compiler-singlepass/src/emitter_x64.rs Show resolved Hide resolved
lib/compiler-singlepass/src/emitter_x64.rs Show resolved Hide resolved
@ptitSeb
Copy link
Contributor Author

ptitSeb commented Nov 23, 2022

General question: do we have codegen test suites that validate behaviour both with and without certain flags?

That would be a huge surface area to test though, so probably not?

No we don't have something like that.

@ptitSeb
Copy link
Contributor Author

ptitSeb commented Nov 24, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 24, 2022

Build succeeded:

@bors bors bot merged commit c3ef0b7 into master Nov 24, 2022
@bors bors bot deleted the feat_singlepass_lzcnt branch November 24, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theduke theduke theduke left review comments

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptitSeb @theduke