Improve FreeBSD support #3365
Merged
Improve FreeBSD support #3365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update `traphandlers.rs` to use the same `pc`/`sp` values for amd64 as
are used for x86
- Ensure amd64 is treated the same as x86_64 in the Makefile
- Add an `IS_FREEBSD` variable to the Makefile which is pretty much the
same as `IS_DARWIN`
- Update CHANGELOG.md
wasmer partially works on FreeBSD/amd64 with these few tiny changes.
However, after printing the output of cowsay.wasm, it hangs for a long
time (55 seconds in this example).
Using rust toolchain `1.63-x86_64-apple-darwin` (correct behavior):
```
% time ./target/release/wasmer cowsay.wasm -- hello world
_____________
< hello world >
-------------
\ ^__^
\ (oo)\_______
(__)\ )\/\
||----w |
|| ||
./target/release/wasmer cowsay.wasm -- hello world 0.01s user 0.01s system 41% cpu 0.061 total
```
Using rust toolchain `1.63-x86_64-unknown-freebsd` (incorrect behavior):
```
% time ./target/release/wasmer cowsay.wasm -- hello world
_____________
< hello world >
-------------
\ ^__^
\ (oo)\_______
(__)\ )\/\
||----w |
|| ||
./target/release/wasmer cowsay.wasm -- hello world 55.14s user 0.05s system 100% cpu 55.183 total
```
cowsay.wasm is https://registry-cdn.wapm.io/contents/syrusakbary/cowsay/0.2.0/target/wasm32-wasi/release/cowsay.wasm
|
To be clear there was already code to support FreeBSD/x86 in |
syrusakbary
approved these changes
Nov 24, 2022
|
bors r+ |
@MalloryA can you create an issue documenting the hang on FreeBSD? That way we will not forget about this after merging. |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
traphandlers.rsto use the samepc/spvalues for amd64 as are used for x86IS_FREEBSDvariable to the Makefile which is pretty much the same asIS_DARWINwasmer partially works on FreeBSD/amd64 with these few tiny changes. However, after printing the output of cowsay.wasm, it hangs for a long time (55 seconds in this example).
Using rust toolchain
1.63-x86_64-apple-darwin(correct behavior):Using rust toolchain
1.63-x86_64-unknown-freebsd(incorrect behavior):cowsay.wasm is https://registry-cdn.wapm.io/contents/syrusakbary/cowsay/0.2.0/target/wasm32-wasi/release/cowsay.wasm
Review