Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do the release on Rust nightly #344

Merged
merged 12 commits into from
Apr 11, 2019
Merged

Do the release on Rust nightly #344

merged 12 commits into from
Apr 11, 2019

Conversation

syrusakbary
Copy link
Member

Do the release on Rust nightly

@syrusakbary
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Apr 11, 2019
@bors
Try #344:
304e121
@bors
Copy link
Contributor

bors bot commented Apr 11, 2019

try

Build succeeded

@syrusakbary
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Apr 11, 2019
@bors
Try #344:
8dafab1
@bors
Copy link
Contributor

bors bot commented Apr 11, 2019

try

Build failed

@lachlansneff
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request Apr 11, 2019
@bors
Try #344:
706b212
@bors
Copy link
Contributor

bors bot commented Apr 11, 2019

try

Build failed

@lachlansneff
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request Apr 11, 2019
@bors
Try #344:
85a4a23
@bors
Copy link
Contributor

bors bot commented Apr 11, 2019

try

Build failed

@lachlansneff
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request Apr 11, 2019
@bors
Try #344:
3f51a8a
@bors
Copy link
Contributor

bors bot commented Apr 11, 2019

try

Build succeeded

@syrusakbary
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 11, 2019

👎 Rejected by too few approved reviews

lachlansneff
lachlansneff approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@lachlansneff lachlansneff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

download

@syrusakbary
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Apr 11, 2019
@bors @syrusakbary @lachlansneff
Merge #344
11b6a5d 
344: Do the release on Rust nightly r=syrusakbary a=syrusakbary

Do the release on Rust nightly

Co-authored-by: Syrus <me@syrusakbary.com>
Co-authored-by: Lachlan Sneff <lachlan.sneff@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 11, 2019

Build succeeded

@bors bors bot merged commit a5fc32f into master Apr 11, 2019
@bors bors bot deleted the feature/nightly-release branch April 11, 2019 23:05
surban pushed a commit to rust-wasi-web/wwrr that referenced this pull request Nov 9, 2024
Merge pull request wasmerio#344 from wasmerio/refactor-package-api
0bc97b6 
Rewrote the top-level `Wasmer` type to be a fancy `Arc<BinaryPackage>`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lachlansneff lachlansneff lachlansneff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syrusakbary @lachlansneff