Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an appveyor file #94

Merged
merged 1 commit into from
Jan 16, 2019
Merged

add an appveyor file #94

merged 1 commit into from
Jan 16, 2019

Conversation

xmclark
Copy link
Contributor

@xmclark xmclark commented Jan 15, 2019

This adds an appveyor file and builds wasmer for Rust Stable x86_64 gnu.

This will fail for awhile until the gnu target is supported, but we can still merge to master.


As long as the circle builds pass, I think this should be merged to master.

@xmclark xmclark force-pushed the improvement/add-appveyor-builds branch from 005fafe to d691bac Compare January 16, 2019 02:26
@xmclark xmclark changed the title wip - add an appveyor file \add an appveyor file Jan 16, 2019
@xmclark xmclark changed the title \add an appveyor file add an appveyor file Jan 16, 2019
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good to merge

PS: In the future we will need to use a tool like ghr to automatically upload the wasmer.exe artifact to the release, like in here: https://github.com/wasmerio/wasmer/blob/master/.circleci/config.yml#L192

@xmclark xmclark merged commit e07e5c7 into master Jan 16, 2019
@xmclark xmclark deleted the improvement/add-appveyor-builds branch January 16, 2019 22:27
MarkMcCaskey pushed a commit that referenced this pull request Apr 14, 2020
nlewycky pushed a commit that referenced this pull request Aug 13, 2020
Optimize singlepass memory access need_check path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants