Linking tags #215
Merged
Linking tags #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't implemented the proper runtime representation of tags in the baseline implementation yet. I am planning to defer that to a separate patch. |
This patch implements support for importing and exporting tags in the virtual machine. As a consequence tags are now unique to their origin instance, meaning that two different instantiations of the same module yields distinct tags. The runtime representation of a tag has changed from an `u32` to a `usize` (or native pointer). The identity of a tag is given by its address in the vmcontext. Resolves wasmfx#25.
dhil
force-pushed
the
wasmfx-linking-tags
branch
from
d9b0343
to
816af74
Compare
Merged
dhil
added a commit
that referenced
this pull request
Oct 4, 2024
This patch updates the README to reflect the recent changes to the CLI. I think the following bullet point in the limitations subsection is outdated: > - Only a single module can be executed. In particular, providing additional > modules using the `--preload` option of `wasmtime` can lead to unexpected > behavior. I think this should work after the proper tags patch #215. Though, I haven't tested it yet, so I will leave it be for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements support for importing and exporting tags in the virtual machine. As a consequence tags are now unique to their origin instance, meaning that two different instantiations of the same module yields distinct tags.
The runtime representation of a tag has changed from an
u32to ausize(or native pointer). The identity of a tag is given by its address in the vmcontext.Resolves #25.