-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Store
is not Send
nor Sync
.
#565
Comments
Thank you for pointing that out! Since we try to mirror the Wasmtime API as good as we can we want our Store to be Send and Sync. We should look into how we can do that most efficiently. |
May I ask what you are using wasmi for? :) |
I'm not currently using wasmi (mainly because of the WASI things). However I'd like to try it, because it is an intepreter instead of JIT, which means it could support more platforms. I'm using WASM for a plugin system in a framework. There are some async and multithreading affairs. It would be good if wasmi supports multithreading by making the types Send and Sync. |
I just created a PR that makes |
wasmi
is a great drop-in replacement forwasmtime
in most cases. However, the typeStore
is notSend
norSync
, which is the biggest difference.Store
is used everywhere, and in my use case,Send
andSync
are needed. Although I canunsafe impl
myself, it would be better to look into the code and find out why they are not implemented.The text was updated successfully, but these errors were encountered: