Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: made some fixes to how WebChatContainer handles mounting and cha… #15

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

TazmanianDI
Copy link
Contributor

…nges to the web chat config

  • The container will now destroy and recreate web chat when the config changes.
  • The container will properly destroy and recreate web chat when unmounted and remounted. This address problems caused in development with React 18's strict mode changes.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Sep 14, 2022

This pull request introduces 1 alert when merging 4dd9708 into 94b4c6b - view on LGTM.com

new alerts:

  • 1 for Useless conditional

ethanwinters
ethanwinters previously approved these changes Sep 19, 2022
Copy link
Member

@ethanwinters ethanwinters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should sync before merge to make sure things are in order for the auto-deploy.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
…nges to the web chat config

- The container will now destroy and recreate web chat when the config changes.
- The container will properly destroy and recreate web chat when unmounted and remounted.
This address problems caused in development with React 18's strict mode changes.
@ethanwinters ethanwinters merged commit d5380dd into main Sep 21, 2022
watson-github-bot pushed a commit that referenced this pull request Sep 21, 2022
## [1.0.3](v1.0.2...v1.0.3) (2022-09-21)

### Bug Fixes

* made some fixes to how WebChatContainer handles mounting and changes to the web chat config ([#15](#15)) ([d5380dd](d5380dd))
@watson-github-bot
Copy link
Member

🎉 This PR is included in version 1.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants