Skip to content

Commit

Permalink
refactor: require filenames for createStopwordList in discovery and…
Browse files Browse the repository at this point in the history
… `convertToHTML` in compare comply

BREAKING CHANGE: The methods `createStopwordList` in discovery and `convertToHTML` in comply comply now have new, required parameters

To migrate your code, include the parameter `stopword_filename` for `createStopwordList`, and `filename` for `convertToHTML`
  • Loading branch information
dpopp07 committed Mar 14, 2019
1 parent ecb5dee commit 8f7c62f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion compare-comply/v1.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class CompareComplyV1 extends BaseService {
public convertToHtml(params: CompareComplyV1.ConvertToHtmlParams, callback?: CompareComplyV1.Callback<CompareComplyV1.HTMLReturn>): Promise<any> | void {
const _params = extend({}, params);
const _callback = callback;
const requiredParams = ['file'];
const requiredParams = ['file', 'filename'];

if (!_callback) {
return new Promise((resolve, reject) => {
Expand Down
2 changes: 1 addition & 1 deletion discovery/v1-generated.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1262,7 +1262,7 @@ class DiscoveryV1 extends BaseService {
public createStopwordList(params: DiscoveryV1.CreateStopwordListParams, callback?: DiscoveryV1.Callback<DiscoveryV1.TokenDictStatusResponse>): Promise<any> | void {
const _params = extend({}, params);
const _callback = (callback) ? callback : () => { /* noop */ };
const requiredParams = ['environment_id', 'collection_id', 'stopword_file'];
const requiredParams = ['environment_id', 'collection_id', 'stopword_file', 'stopword_filename'];

if (!_callback) {
return new Promise((resolve, reject) => {
Expand Down

0 comments on commit 8f7c62f

Please sign in to comment.