Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup sample app and sometimes it looks like bricks are disappearing #142

Closed
rubencagnie opened this issue Jul 7, 2017 · 0 comments
Closed

Cleanup sample app and sometimes it looks like bricks are disappearing #142

rubencagnie opened this issue Jul 7, 2017 · 0 comments

Comments

@rubencagnie
Copy link
Contributor

Some places of the sample app have been broken by the swift 3 conversion. Typical issues are dataSource methods that have changed signature, but had a default implementation

There is also a bug that occurs when specifying a large estimated height, but the actual height is much smaller. This causes some bricks to disappear when scrolling
rubencagnie added a commit that referenced this issue Jul 7, 2017
@rubencagnie
Cleanup Sample App + Fixed “dissapearing bricks”
6f71d7a 
- Cleanup the sample app. Mainly update protocols that changed function signatures, but had a default implementation, so the compiler didn’t complain
- Fixed a weird behavior when bricks would disappear when the estimated height of a brick was much bigger than the actual brick. This is solved by setting the `invalidateItems` to nil, so the collectionView will fetch the layoutAttributes again

Fixes #142
@rubencagnie rubencagnie mentioned this issue Jul 7, 2017
Merged
rubencagnie added a commit that referenced this issue Jul 7, 2017
@rubencagnie
Cleanup Sample App + Fixed “dissapearing bricks”
bed9285 
- Cleanup the sample app. Mainly update protocols that changed function signatures, but had a default implementation, so the compiler didn’t complain
- Fixed a weird behavior when bricks would disappear when the estimated height of a brick was much bigger than the actual brick. This is solved by setting the `invalidateItems` to nil, so the collectionView will fetch the layoutAttributes again

Fixes #142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rubencagnie