Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added update edgeInsets logic #189

Conversation

pcheung16
Copy link
Contributor

Reverts #184

@codecov-io
Copy link

codecov-io commented Sep 22, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@fa2d3ad). Click here to learn what that means.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #189   +/-   ##
=========================================
  Coverage          ?   93.39%           
=========================================
  Files             ?       40           
  Lines             ?     4403           
  Branches          ?      361           
=========================================
  Hits              ?     4112           
  Misses            ?      290           
  Partials          ?        1
Impacted Files Coverage Δ
Source/Cells/BrickCell.swift 97.35% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa2d3ad...e8cab41. Read the comment docs.

@pcheung16 pcheung16 force-pushed the revert-184-remove-update-edge-insets branch from 10481bf to e8cab41 Compare September 25, 2017 19:09
@pcheung16 pcheung16 changed the title Revert "Removed code that caused edgeInsets to update incorrectly" Added update edgeInsets logic Sep 25, 2017
@jay18001 jay18001 merged commit 99a323c into wayfair-archive:master Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants