-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated height provider code to be a closure #191
Conversation
…bility in specifying a custom height.
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
=========================================
Coverage ? 93.41%
=========================================
Files ? 40
Lines ? 4392
Branches ? 359
=========================================
Hits ? 4103
Misses ? 288
Partials ? 1
Continue to review full report at Codecov.
|
@@ -77,7 +73,7 @@ open class GenericBrickCell: BrickCell { | |||
} | |||
} | |||
|
|||
open var customHeightProvider: CustomHeightProvider? | |||
open var customHeightProvider: ((_ width: CGFloat) -> CGFloat)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put this in a typealias
… Edge Insets Functionality Squashed Commit of the following: commit 89ef650 Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Thu Nov 9 10:16:10 2017 -0500 Added additional verbose logging to refresh/reloading of data. commit cee70e8 Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Thu Nov 2 15:05:39 2017 -0400 Clear prefetch index paths upon invalidation. Written by nlobue commit c760425 Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Mon Oct 30 16:50:56 2017 -0400 Fix for a crash that can occur if the first index is greater the number of items. commit a838e8d Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Mon Oct 23 14:15:58 2017 -0400 Updated height provider code to be a closure (wayfair-archive#191). Fix by vlozko. commit 5e21936 Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Wed Oct 18 14:06:09 2017 -0400 Fix for crash commit 48846ee Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Fri Oct 13 10:04:59 2017 -0400 Attempt to fix a crash commit e6d3c6d Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Thu Oct 5 17:28:58 2017 -0400 Added a flag that determines which version of the inset updating code is run.
… Edge Insets Functionality (#202) * Stability, Layout, and Logging Enhancements; Added Support for Legacy Edge Insets Functionality Squashed Commit of the following: commit 89ef650 Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Thu Nov 9 10:16:10 2017 -0500 Added additional verbose logging to refresh/reloading of data. commit cee70e8 Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Thu Nov 2 15:05:39 2017 -0400 Clear prefetch index paths upon invalidation. Written by nlobue commit c760425 Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Mon Oct 30 16:50:56 2017 -0400 Fix for a crash that can occur if the first index is greater the number of items. commit a838e8d Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Mon Oct 23 14:15:58 2017 -0400 Updated height provider code to be a closure (#191). Fix by vlozko. commit 5e21936 Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Wed Oct 18 14:06:09 2017 -0400 Fix for crash commit 48846ee Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Fri Oct 13 10:04:59 2017 -0400 Attempt to fix a crash commit e6d3c6d Author: Will Spurgeon <wspurgeon@wayfair.com> Date: Thu Oct 5 17:28:58 2017 -0400 Added a flag that determines which version of the inset updating code is run. * Fix crash when changing repeat counts; Add unit tests for it * Line spacing fix, per PR comment * Replace XCTAssertEqual with XCTAssertEqualWithAccuracy due to Swift version
Allows for more flexibility in specifying a custom height. Also happens to fix a potential memory leak.