Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background colors should default to .clear not .white. #193

Conversation

willspurgeon
Copy link
Contributor

Slight change to the prepareForReuse functions for LabelBrick and ButtonBrick. The background colors should default to .clear instead of .white.

@codecov-io
Copy link

codecov-io commented Oct 4, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@8d815f0). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #193   +/-   ##
========================================
  Coverage          ?   93.5%           
========================================
  Files             ?      40           
  Lines             ?    4449           
  Branches          ?     363           
========================================
  Hits              ?    4160           
  Misses            ?     288           
  Partials          ?       1
Impacted Files Coverage Δ
Source/Bricks/Button/ButtonBrick.swift 86.36% <100%> (ø)
Source/Bricks/Label/LabelBrick.swift 85.18% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d815f0...cb8e4ed. Read the comment docs.

@jay18001 jay18001 merged commit 2758132 into wayfair-archive:master Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants