Xcode 9.3/Swift 4.1 upgrade #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jay18001
reviewed
Feb 27, 2018
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
=========================================
Coverage ? 92.56%
=========================================
Files ? 40
Lines ? 3552
Branches ? 0
=========================================
Hits ? 3288
Misses ? 264
Partials ? 0
Continue to review full report at Codecov.
|
|
Can you update the swift version file to 4.2 |
added 4 commits
April 9, 2018 17:27
|
This is ready for merging |
jay18001
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP PR to track necessary configuration and code changes needed to remove warnings from the builds on Xcode 9.3 beta. Initial commit tested with Xcode 9.3 beta 3.