-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use platform editor component instead of our own #5039
Comments
Currently, They have this issue to update Monaco in 2.7.0 And in OUI they have this issue that from what I understand is not a priority for them, the code editor component. I have been testing the Monaco implementation offered by Opensearch, but I can't get the formatting right. |
Looking at the opensearch code, I saw that they still have the And I also saw that you intend to add more information about Monaco. |
I have seen that the custom version of monaco offered in opensearch uses react-monaco-editor in addition to monaco-editor, and I created a new project to see how it works and by default the same thing happens to me, it does not look with styles, so I am testing to see what configuration would be the most appropriate for the project. |
I created this issue in the OpenSerach Dashboards repository, and they replied that you have to add the file with the language you want to add. I was testing, and we would have to first integrate the language and then make the change from the current editor to the one that OpenSearch Dashboard tested. |
I share the file with the one I managed to make it look similar, but it needs to be finished. |
These problems
is related to the For this case, and due to the syntax and behavior being similar to the |
Describe the solution you'd like
Evaluate if we can reuse the platform editor instead of our own as an editor component.
Additional context
This will allow us to use less dependencies.
Related issues
<
character #3504The text was updated successfully, but these errors were encountered: