Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wazuh main menu is not displayed when the navigation menu is locked #5264

Closed
sultanovich opened this issue Mar 7, 2023 · 3 comments · Fixed by #5273
Closed

Wazuh main menu is not displayed when the navigation menu is locked #5264

sultanovich opened this issue Mar 7, 2023 · 3 comments · Fixed by #5273
Assignees
Labels
type/bug Bug issue

Comments

@sultanovich
Copy link
Member

Wazuh OpenSearch Rev Security
4.4 2.4.1 03 Basic
Browser
Chrome, Brave

Description
When the navigation panel is locked, the main Wazuh menu is not visible.

Preconditions

Steps to reproduce

  1. Navigate to the main menu
    image

  2. Click on 'Dock navigation'
    image

  3. Display Wazuh's main menu
    image

Expected Result
The Wazuh main menu should be displayed as it is shown when the navigation menu is not locked.
image

Screenshots

Actual Result
The Wazuh main menu is currently not displayed.
image

Additional context
The same behavior has been verified using the OVA image and the .tar.gz package.

@sultanovich sultanovich added the type/bug Bug issue label Mar 7, 2023
@asteriscos
Copy link
Member

asteriscos commented Mar 7, 2023

Research

Changing this style z-index to 999 fixes the problem:

https://github.com/wazuh/wazuh-kibana-app/blob/v4.3.10-1.2.0/public/components/wz-menu/wz-menu.scss#L104-L106

  • If the Side menu is docked, then Wazuh Navigation menu will be on top.
  • If the Side menu is NOT docked, then Wazuh Navigation menu will be beneath the grey overlay which has a z-index of 1000.
Peek.2023-03-07.13-27.mp4

@yenienserrano yenienserrano self-assigned this Mar 8, 2023
@yenienserrano yenienserrano linked a pull request Mar 8, 2023 that will close this issue
6 tasks
@Desvelao Desvelao moved this from Triage to In Progress in Release 4.4.0 Mar 9, 2023
@yenienserrano
Copy link
Member

Trying to replicate it in kibana 7.17.6, I noticed that it does not have a button to lock the menu.
Looking at the code of kibana 7.17.6 I saw that they are hiding the button,
They are using a component of elastic eui called EuiShowFor where you pass a parameter "sizes" that you put all the window sizes that you want to be rendered and from kibana 7.16.0 and changed the value to "none", in kibana 7.10 has in sizes "l" and "xl".

@yenienserrano yenienserrano moved this from In Progress to In Review in Release 4.4.0 Mar 9, 2023
@yenienserrano
Copy link
Member

yenienserrano commented Mar 9, 2023

Trying to replicate it in kibana 7.10.2, I saw that it does not have the problem of this issue, it works fine when the menu is locked, but when it is not locked the wazuh menu is still on top of everything.

screenshots

image

image

Already happened in 4.3.10

screenshots

Image

Image

@github-project-automation github-project-automation bot moved this from In Review to Done in Release 4.4.0 Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Bug issue
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants