Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remove discover] Implement embeddable dashboard on Virustotal module #6511

Closed
18 tasks done
Tracked by #6477
jbiset opened this issue Mar 13, 2024 · 5 comments · Fixed by #6525
Closed
18 tasks done
Tracked by #6477

[Remove discover] Implement embeddable dashboard on Virustotal module #6511

jbiset opened this issue Mar 13, 2024 · 5 comments · Fixed by #6525
Assignees
Labels
level/subtask Subtask issue type/enhancement Enhancement issue

Comments

@jbiset
Copy link
Member

jbiset commented Mar 13, 2024

Description

We have to implement the embeddable dashboard on Virustotal -> dashboard tab and deprecate any use of kibana-integrations components.

Warning

The embeddable panel id must be unique including general and agents visualizations. Otherwise, the visualizations will not refresh when we pin an agent, because they are cached by id

Current VirusTotal screens

Virustotal-A

Virustotal-B

Virustotal-C

Virustotal-A_pinnedAgent

Tasks

  • Implement the embeddable dashboard on Virustotal -> dashboard tab
    • Migrate visualizations to embeddable panels
    • Add new searchbar
    • Add SampleDataMessage
    • Add conditionality to show the dashboard if there are results.
    • Add loadings
    • Add message that there are no results
    • Change index pattern selection mechanism (Dependence: [Remove discover] Change index pattern selector mechanism #6434)
    • Change pinned agent recognition mechanism (Dependence: Standardize filter management mechanisms #6499)
    • Once the two previous points have been applied, corroborate filter behavior with respect to hide alerts, allow agents and filter order.
  • Check the following:
    • Each visualization, if applicable, must have interaction so that it adds the corresponding filter(s) upon clicking.
    • The visualizations have to be updated according to the filters applied in the searchbar.
    • The visualizations have to be updated when a search is performed in the searchbar.
    • If there are no results, the corresponding message must appear that there are no results and the visualizations should not be rendered.
    • If there is SampleData, the corresponding SampleData message must appear.
    • If an agent is pinned, the views must be updated and changed to the agent view, if applicable.
    • Check filter behavior with respect to hide alerts, allow agents and filter order.

Source task

@jbiset
Copy link
Member Author

jbiset commented Mar 15, 2024

Update 15/03/2024

The following is resolved:

  • Migrated visualizations to embeddable panels
  • Added new searchbar
  • Added SampleDataMessage
  • Added conditionality to show the dashboard if there are results.
  • Added loadings
  • Added message that there are no results

Evidence

Evidence_updates.webm

NOTE: In the Virustotal dashboard without having the agent pinned, it is proposed to change "Unique malicious files per agent" to "Top 5 agents with unique malicious files" since it better reflects what is being shown.

The task is blocked until the dependencies are resolved

@wazuhci wazuhci moved this from In progress to Blocked in Release 4.9.0 Mar 15, 2024
@wazuhci wazuhci moved this from Blocked to In progress in Release 4.9.0 Apr 12, 2024
@jbiset
Copy link
Member Author

jbiset commented Apr 15, 2024

Update 15/04/2024

  • Functionality of the new data source is integrated by creating an alerts-virustotal-data-source
  • Common NoResults component is incorporated
  • Common LoadingSpinner component is incorporated
  • Conditionals are adjusted in the dashboard according to the data source

TO DO:

  • Fix implicit/fixed virustotal filters
  • Fix Events tab with new data source

Current screen

image

@jbiset
Copy link
Member Author

jbiset commented Apr 17, 2024

Update 17/04/2024

Changed pinned agent recognition mechanism according to the new data source

Evidence_pinnedAgent.webm

@jbiset
Copy link
Member Author

jbiset commented Apr 18, 2024

Update 18/04/2024

  • Added timeRange to dashboard useEffect dependencies
  • Changed the way to get pinned agent
  • The problem of why the AppState.clusterInfo is not updated correctly is analyzed. Since when exchanging between manager and cluster mode it usually happens that the value does not change and the enabled cluster remains in manager mode. However, the problem is not particular to this Issue, as well as the problem of implicit/fixed filters that do not eliminate the "x"
  • The evidence of the PR is completed and it is placed in Pending review

@wazuhci wazuhci moved this from In progress to Pending review in Release 4.9.0 Apr 18, 2024
@wazuhci wazuhci moved this from Pending review to In review in Release 4.9.0 Apr 19, 2024
@wazuhci wazuhci moved this from In review to Pending final review in Release 4.9.0 Apr 24, 2024
@jbiset
Copy link
Member Author

jbiset commented Apr 24, 2024

Update 24/04/2024

  • Changed AlertsVirustotalDataSource import in modules-defaults
  • Fixed error message
  • DashboardByRenderer timeRange params replaced by searchBarProps deconstruction
  • Added hide-filter-control classes to hide the button thatallows you to affect all the filters in the search bar
  • Removed unnecessary virustotal in tabFilters in common data to remove duplicate filters
  • Removed unused files
  • Added dateRange param to fetchData in dashboard useEffect

@wazuhci wazuhci moved this from Pending final review to Done in Release 4.9.0 Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/subtask Subtask issue type/enhancement Enhancement issue
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants