Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename vulnerability.under_evaluation field #7046

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Rename vulnerability.under_evaluation field #7046

merged 3 commits into from
Oct 2, 2024

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Oct 1, 2024 •
edited
Loading

Description

This pull request renames the vulnerability.under_evaluation field.

Issues Resolved

#7045

Evidence

image

image

Test

  • Load vulnerabilities sample data
  • Navigate to Vulnerabilities module / Dashboard
  • Verify the Pending evaluation KPI has data
  • Use the Under evaluation custom filter and check it filters
  • Navigate to Vulnerabilities module / Inventory
  • Filter an under evaluation document
  • Verify the document details value is consistent with the filter applied

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos linked an issue Oct 1, 2024 that may be closed by this pull request
Change vulnerability.under_evaluation field #7045
Closed
Tostti
Tostti previously approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asteriscos asteriscos self-assigned this Oct 1, 2024
@Dwordcito Dwordcito mentioned this pull request Oct 2, 2024
Closed
6 tasks
@JuanGarriuz JuanGarriuz self-requested a review October 2, 2024 07:12
JuanGarriuz
JuanGarriuz previously approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test 🟢

image

image

CR 🟢

LGTM!!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Main plugin code coverage (Jest) test % values
Statements 14.09% ( 4177 / 29637 )
Branches 9.18% ( 1771 / 19290 )
Functions 13.74% ( 985 / 7166 )
Lines 14.28% ( 4075 / 28523 )

@asteriscos asteriscos merged commit 1ae35d8 into 4.10.0 Oct 2, 2024
5 checks passed
@asteriscos asteriscos deleted the change/7045-change-vulnerability.under_evaluation-field-name branch October 2, 2024 10:04
@asteriscos asteriscos mentioned this pull request Oct 21, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tostti Tostti Tostti approved these changes

@JuanGarriuz JuanGarriuz JuanGarriuz left review comments

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change vulnerability.under_evaluation field
3 participants
@asteriscos @Tostti @JuanGarriuz