Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Avoid to remove the implicit filters in the modules #4146

Merged
merged 3 commits into from
May 25, 2022

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented May 16, 2022

Description

This PR fixes the possibility to remove the implicit filters in the modules.

Changes

  • Restored the change from match to match_phrase when seeing the filters in the search bar.
  • Restored the use of .meta.value() for Kibana 7.16.x-7.17.x.

These changes were introduced previously in:

Closes #4144

  - Restore the filter of `match_phrase`
  - Use `.meta.value()` instead of `.meta.value`
@Desvelao Desvelao added the type/bug Bug issue label May 16, 2022
@Desvelao Desvelao self-assigned this May 16, 2022
@Desvelao Desvelao force-pushed the fix/4144-not-allow-remove-implicit-filters branch from 009d895 to abb0f29 Compare May 16, 2022 11:27
…into fix/4144-not-allow-remove-implicit-filters
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code Review: ✔️
  • Testing: ✔️

@AlexRuiz7 AlexRuiz7 merged commit 74b82e0 into 4.3-7.16 May 25, 2022
@AlexRuiz7 AlexRuiz7 deleted the fix/4144-not-allow-remove-implicit-filters branch May 25, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Bug issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Kibana][>=7.16.x] Avoid the posibility to remove the implicit filters
3 participants