Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Replaced as the full and partial scan dates are displayed in the Details panel in Vulnerabilites/Inventory #4169

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented May 26, 2022

Description

This PR replaces as the full and partial scan dates are displayed in the Details panel in Vulnerabilities/Inventory

Changes

  • Use the same component that renders data in the agent overview

Screenshot

image

Test

  • Generate vulnerabilities for an agent and go to Vulnerabilities/Inventory and see the Details` panel, the dates should be rendered as expected

Closes #4049

@Desvelao Desvelao self-assigned this May 26, 2022
@Desvelao Desvelao added type/enhancement Enhancement issue UI/UX Generic label for things related to the font-end side labels May 26, 2022
Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CHANGELOG.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 4.04% ( 1478 / 36563 )
Branches 1.62% ( 461 / 28437 )
Functions 2.99% ( 267 / 8935 )
Lines 4.09% ( 1430 / 34958 )

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…into fix/4049-replace-rendering-date-full-partial-vulnerabilities-scans-on-vulnerabilites-inventory-details
@Desvelao Desvelao merged commit f8a9ec8 into 4.3-7.10 Jun 2, 2022
@Desvelao Desvelao deleted the fix/4049-replace-rendering-date-full-partial-vulnerabilities-scans-on-vulnerabilites-inventory-details branch June 2, 2022 08:33
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

The backport to 4.3-7.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.3-7.16 4.3-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.3-7.16
# Create a new branch
git switch --create backport-4169-to-4.3-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f8a9ec8578835b20c08b31e69841b5b5aca29402
# Push it to GitHub
git push --set-upstream origin backport-4169-to-4.3-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.3-7.16

Then, create a pull request where the base branch is 4.3-7.16 and the compare/head branch is backport-4169-to-4.3-7.16.

github-actions bot pushed a commit that referenced this pull request Jun 2, 2022
… Details panel in Vulnerabilites/Inventory (#4169)

* feat: replace the rendering of full and partial scan dates in Vulnerabilities/Inventory

* changelog: add PR entry

* fix: Changed the title size

* Update CHANGELOG.md

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit f8a9ec8)
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

The backport to cloud/4.3-7.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-cloud/4.3-7.10 cloud/4.3-7.10
# Navigate to the new working tree
cd .worktrees/backport-cloud/4.3-7.10
# Create a new branch
git switch --create backport-4169-to-cloud/4.3-7.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f8a9ec8578835b20c08b31e69841b5b5aca29402
# Push it to GitHub
git push --set-upstream origin backport-4169-to-cloud/4.3-7.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-cloud/4.3-7.10

Then, create a pull request where the base branch is cloud/4.3-7.10 and the compare/head branch is backport-4169-to-cloud/4.3-7.10.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

The backport to cloud/4.3-7.10-custom-agents-view failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-cloud/4.3-7.10-custom-agents-view cloud/4.3-7.10-custom-agents-view
# Navigate to the new working tree
cd .worktrees/backport-cloud/4.3-7.10-custom-agents-view
# Create a new branch
git switch --create backport-4169-to-cloud/4.3-7.10-custom-agents-view
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f8a9ec8578835b20c08b31e69841b5b5aca29402
# Push it to GitHub
git push --set-upstream origin backport-4169-to-cloud/4.3-7.10-custom-agents-view
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-cloud/4.3-7.10-custom-agents-view

Then, create a pull request where the base branch is cloud/4.3-7.10-custom-agents-view and the compare/head branch is backport-4169-to-cloud/4.3-7.10-custom-agents-view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Enhancement issue UI/UX Generic label for things related to the font-end side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the visibility of the information displayed in the Table Details of the "Inventory" section.
3 participants