Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX][Kibana][7.16.x-7.17.x] Fix error when building the visualizations #4196

Merged
merged 2 commits into from
Jun 3, 2022
Merged

[FIX][Kibana][7.16.x-7.17.x] Fix error when building the visualizations #4196

merged 2 commits into from
Jun 3, 2022

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Jun 3, 2022 •
edited
Loading

Description

This PR fixes an error when building the core visualizations for the plugins for Kibana 7.16.x and 7.17.x.

Changes

  • fix an error when building the core visualizations
  • fix error in the Agents section caused by a not defined class.

Test

  • Navigate to any section which has a core visualization. This should be displayed.

Closes #4195

@Desvelao
fix: fix error when building the core visualizations
dcf2df7 
  - fix error in the `Agents` section caused by a not defined class.
@Desvelao Desvelao self-assigned this Jun 3, 2022
@Desvelao Desvelao added the type/bug Bug issue label Jun 3, 2022
@Desvelao Desvelao changed the title [FIX] Fix error when building the visualizations [FIX][Kibana][7.16.x-7.17.x] Fix error when building the visualizations Jun 3, 2022
asteriscos
asteriscos approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

yenienserrano
yenienserrano approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: ✔️

@asteriscos asteriscos merged commit a8c8dc3 into 4.3-7.16 Jun 3, 2022
@asteriscos asteriscos deleted the fix/4195-errors-build-visualizations branch June 3, 2022 08:54
@Desvelao Desvelao linked an issue Jun 3, 2022 that may be closed by this pull request
[Kibana][7.16.x] Visualizations are not displayed #4195
Closed
@Desvelao Desvelao mentioned this pull request Jun 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@asteriscos asteriscos asteriscos approved these changes

Assignees

@Desvelao Desvelao

Labels
type/bug Bug issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Kibana][7.16.x] Visualizations are not displayed
3 participants
@Desvelao @asteriscos @yenienserrano