-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Plugin crash when searching with a query with syntax errors in Modules/Security events #4237
[BUG] Plugin crash when searching with a query with syntax errors in Modules/Security events #4237
Conversation
…ery syntax in Modules/Security events Replaced the error level from `CRITICAL` to `BUSINESS`. With this change, a toast will be displayed with the error. Removed the storing of the error in the plugin logs related to UI. Removed unused variable
065c06d
to
ef1b06e
Compare
…r-modules-security-events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review: ✔️
Test: ✔️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR ✅
Test ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: ✔️
Test: ✔️
the issue is resolved, 2 issues were found after resolving this issue
…r-modules-security-events
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.3-7.16 4.3-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.3-7.16
# Create a new branch
git switch --create backport-4237-to-4.3-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 431c20465264e9dc490fa58dcf1287a727ae9b1e
# Push it to GitHub
git push --set-upstream origin backport-4237-to-4.3-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.3-7.16 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.3-1.2-wzd 4.3-1.2-wzd
# Navigate to the new working tree
cd .worktrees/backport-4.3-1.2-wzd
# Create a new branch
git switch --create backport-4237-to-4.3-1.2-wzd
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 431c20465264e9dc490fa58dcf1287a727ae9b1e
# Push it to GitHub
git push --set-upstream origin backport-4237-to-4.3-1.2-wzd
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.3-1.2-wzd Then, create a pull request where the |
…Modules/Security events (#4237) * fix: fixed plugin UI crash when there is an error related to wrong query syntax in Modules/Security events Replaced the error level from `CRITICAL` to `BUSINESS`. With this change, a toast will be displayed with the error. Removed the storing of the error in the plugin logs related to UI. Removed unused variable * changelog: Add PR entry Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
…Modules/Security events (#4237) * fix: fixed plugin UI crash when there is an error related to wrong query syntax in Modules/Security events Replaced the error level from `CRITICAL` to `BUSINESS`. With this change, a toast will be displayed with the error. Removed the storing of the error in the plugin logs related to UI. Removed unused variable * changelog: Add PR entry Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
…Modules/Security events (#4237) * fix: fixed plugin UI crash when there is an error related to wrong query syntax in Modules/Security events Replaced the error level from `CRITICAL` to `BUSINESS`. With this change, a toast will be displayed with the error. Removed the storing of the error in the plugin logs related to UI. Removed unused variable * changelog: Add PR entry Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
Description
This PR fixes a plugin crash when searching with a query with syntax errors in
Modules/Security events
.Screenshot
Closes #4168
Test
Modules/Security events
and search with a query with syntax errors, by example:test()
The plugin UI should not crash and should display toast messages with the errors.