Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruleset test messages #4244

Merged
merged 7 commits into from
Jun 14, 2022
Merged

Ruleset test messages #4244

merged 7 commits into from
Jun 14, 2022

Conversation

yenienserrano
Copy link
Member

Description:

When a user goes to test a new rule in Tools -> Ruleset Test, we were getting API messages that were not displayed. Now if there are messages they are displayed on the screen.

Issue:

Test:

  1. Navigate to 'Tools -> Ruleset Test'
  2. Run test
  3. Check that the messages appear, if there are no messages see that the request does not return messages

Screenshot:

image

message.mp4

@yenienserrano yenienserrano changed the title 4111 rules testing messages Ruleset test messages Jun 13, 2022
@yenienserrano yenienserrano requested a review from a team June 13, 2022 09:36
@yenienserrano yenienserrano linked an issue Jun 13, 2022 that may be closed by this pull request
@Desvelao Desvelao added UI/UX Generic label for things related to the font-end side type/enhancement Enhancement issue labels Jun 13, 2022
Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code review: ✔️
  • Test: ✔️

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review
code ✔️
test ✔️

@Desvelao Desvelao merged commit 92ed97d into 4.3-7.10 Jun 14, 2022
@Desvelao Desvelao deleted the 4111-rules-testing-messages branch June 14, 2022 07:12
github-actions bot pushed a commit that referenced this pull request Jun 14, 2022
* 2 proposals

* cleaning

* add changelog

* suggested changes

* fix(logtest): changed Array.prototype.reduce by Array.prototype.forEach to display the messages

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com>
(cherry picked from commit 92ed97d)
github-actions bot pushed a commit that referenced this pull request Jun 14, 2022
* 2 proposals

* cleaning

* add changelog

* suggested changes

* fix(logtest): changed Array.prototype.reduce by Array.prototype.forEach to display the messages

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com>
(cherry picked from commit 92ed97d)
Desvelao pushed a commit that referenced this pull request Jun 14, 2022
Ruleset test messages (#4244)

* 2 proposals

* cleaning

* add changelog

* suggested changes

* fix(logtest): changed Array.prototype.reduce by Array.prototype.forEach to display the messages

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com>
(cherry picked from commit 92ed97d)

Co-authored-by: Ian Yenien Serrano <63758389+yenienserrano@users.noreply.github.com>
Desvelao pushed a commit that referenced this pull request Jun 14, 2022
Ruleset test messages (#4244)

* 2 proposals

* cleaning

* add changelog

* suggested changes

* fix(logtest): changed Array.prototype.reduce by Array.prototype.forEach to display the messages

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com>
(cherry picked from commit 92ed97d)

Co-authored-by: Ian Yenien Serrano <63758389+yenienserrano@users.noreply.github.com>
@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 4.09% ( 1489 / 36388 )
Branches 1.67% ( 473 / 28244 )
Functions 3.06% ( 272 / 8898 )
Lines 4.14% ( 1440 / 34805 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Enhancement issue UI/UX Generic label for things related to the font-end side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rules - testing messages do not appear as feedback to the user
3 participants