-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruleset test messages #4244
Merged
Merged
Ruleset test messages #4244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desvelao
added
UI/UX
Generic label for things related to the font-end side
type/enhancement
Enhancement issue
labels
Jun 13, 2022
Desvelao
reviewed
Jun 13, 2022
Desvelao
reviewed
Jun 13, 2022
AlexRuiz7
approved these changes
Jun 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Code review: ✔️
- Test: ✔️
…ch to display the messages
Desvelao
approved these changes
Jun 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review
code ✔️
test ✔️
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2022
* 2 proposals * cleaning * add changelog * suggested changes * fix(logtest): changed Array.prototype.reduce by Array.prototype.forEach to display the messages Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> (cherry picked from commit 92ed97d)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2022
* 2 proposals * cleaning * add changelog * suggested changes * fix(logtest): changed Array.prototype.reduce by Array.prototype.forEach to display the messages Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> (cherry picked from commit 92ed97d)
Desvelao
pushed a commit
that referenced
this pull request
Jun 14, 2022
Ruleset test messages (#4244) * 2 proposals * cleaning * add changelog * suggested changes * fix(logtest): changed Array.prototype.reduce by Array.prototype.forEach to display the messages Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> (cherry picked from commit 92ed97d) Co-authored-by: Ian Yenien Serrano <63758389+yenienserrano@users.noreply.github.com>
Desvelao
pushed a commit
that referenced
this pull request
Jun 14, 2022
Ruleset test messages (#4244) * 2 proposals * cleaning * add changelog * suggested changes * fix(logtest): changed Array.prototype.reduce by Array.prototype.forEach to display the messages Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> Co-authored-by: Antonio David Gutiérrez <antonio.gutierrez@wazuh.com> (cherry picked from commit 92ed97d) Co-authored-by: Ian Yenien Serrano <63758389+yenienserrano@users.noreply.github.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When a user goes to test a new rule in Tools -> Ruleset Test, we were getting API messages that were not displayed. Now if there are messages they are displayed on the screen.
Issue:
Test:
Screenshot:
message.mp4