Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rules/Decoders/CDB lists uploader to show errors appropriately #4307

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Jul 5, 2022

Description

This PR adds error management to the action buttons of Rules/Decoders/CDB Lists' tables.

If there is some error in the action button, a toast should be displayed with the error.

Closes #4288.

Screenshots

image
image
Related to: #4288

Tests

  • Test and provoke errors in the action buttons of Rules/Decoders/CDB Lists' tables, a toast should be displayed with the information about the error.

@Desvelao Desvelao linked an issue Jul 5, 2022 that may be closed by this pull request
…into fix/4288-add-error-management-actions-rules-decodres-cdblists
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

@Desvelao Desvelao requested a review from AlexRuiz7 July 6, 2022 12:01
Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

Jest Test Coverage % values
Statements 5.5% ( 1999 / 36376 )
Branches 2.28% ( 643 / 28227 )
Functions 3.67% ( 326 / 8891 )
Lines 5.57% ( 1938 / 34793 )

@AlexRuiz7 AlexRuiz7 merged commit 0a1a9d0 into 4.3-7.10 Jul 8, 2022
@AlexRuiz7 AlexRuiz7 deleted the fix/4288-add-error-management-actions-rules-decodres-cdblists branch July 8, 2022 09:02
github-actions bot pushed a commit that referenced this pull request Jul 8, 2022
…es (#4307)

* fix: add error management to the actions buttons of tables in rules/decoders/cdb lists

* changelog: add PR entry

* fix: unified error management in the actions of buttons of Rules/Decoders/CDB Lists's table

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit 0a1a9d0)
github-actions bot pushed a commit that referenced this pull request Jul 8, 2022
…es (#4307)

* fix: add error management to the actions buttons of tables in rules/decoders/cdb lists

* changelog: add PR entry

* fix: unified error management in the actions of buttons of Rules/Decoders/CDB Lists's table

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit 0a1a9d0)
AlexRuiz7 pushed a commit that referenced this pull request Jul 8, 2022
…ders/CDB Lists' tables (#4315)

Add error management to actions of the Rules/Decoders/CDB Lists' tables (#4307)

* fix: add error management to the actions buttons of tables in rules/decoders/cdb lists

* changelog: add PR entry

* fix: unified error management in the actions of buttons of Rules/Decoders/CDB Lists's table

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit 0a1a9d0)

Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com>
AlexRuiz7 pushed a commit that referenced this pull request Jul 8, 2022
…ecoders/CDB Lists' tables (#4316)

Add error management to actions of the Rules/Decoders/CDB Lists' tables (#4307)

* fix: add error management to the actions buttons of tables in rules/decoders/cdb lists

* changelog: add PR entry

* fix: unified error management in the actions of buttons of Rules/Decoders/CDB Lists's table

Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit 0a1a9d0)

Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com>
@AlexRuiz7 AlexRuiz7 changed the title Add error management to actions of the Rules/Decoders/CDB Lists' tables Fix Rules/Decoders/CDB lists uploader to show error appropriately Jul 15, 2022
@AlexRuiz7 AlexRuiz7 changed the title Fix Rules/Decoders/CDB lists uploader to show error appropriately Fix Rules/Decoders/CDB lists uploader to show errors appropriately Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Large CDB lists upload fails silently
3 participants