-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Rules/Decoders/CDB lists uploader to show errors appropriately #4307
Merged
AlexRuiz7
merged 5 commits into
4.3-7.10
from
fix/4288-add-error-management-actions-rules-decodres-cdblists
Jul 8, 2022
Merged
Fix Rules/Decoders/CDB lists uploader to show errors appropriately #4307
AlexRuiz7
merged 5 commits into
4.3-7.10
from
fix/4288-add-error-management-actions-rules-decodres-cdblists
Jul 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecoders/cdb lists
…into fix/4288-add-error-management-actions-rules-decodres-cdblists
yenienserrano
approved these changes
Jul 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: ✔️
Test: ✔️
AlexRuiz7
reviewed
Jul 6, 2022
public/controllers/management/components/management/ruleset/utils/columns.tsx
Outdated
Show resolved
Hide resolved
…ders/CDB Lists's table
AlexRuiz7
approved these changes
Jul 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
AlexRuiz7
deleted the
fix/4288-add-error-management-actions-rules-decodres-cdblists
branch
July 8, 2022 09:02
github-actions bot
pushed a commit
that referenced
this pull request
Jul 8, 2022
…es (#4307) * fix: add error management to the actions buttons of tables in rules/decoders/cdb lists * changelog: add PR entry * fix: unified error management in the actions of buttons of Rules/Decoders/CDB Lists's table Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 0a1a9d0)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 8, 2022
…es (#4307) * fix: add error management to the actions buttons of tables in rules/decoders/cdb lists * changelog: add PR entry * fix: unified error management in the actions of buttons of Rules/Decoders/CDB Lists's table Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 0a1a9d0)
AlexRuiz7
pushed a commit
that referenced
this pull request
Jul 8, 2022
…ders/CDB Lists' tables (#4315) Add error management to actions of the Rules/Decoders/CDB Lists' tables (#4307) * fix: add error management to the actions buttons of tables in rules/decoders/cdb lists * changelog: add PR entry * fix: unified error management in the actions of buttons of Rules/Decoders/CDB Lists's table Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 0a1a9d0) Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com>
AlexRuiz7
pushed a commit
that referenced
this pull request
Jul 8, 2022
…ecoders/CDB Lists' tables (#4316) Add error management to actions of the Rules/Decoders/CDB Lists' tables (#4307) * fix: add error management to the actions buttons of tables in rules/decoders/cdb lists * changelog: add PR entry * fix: unified error management in the actions of buttons of Rules/Decoders/CDB Lists's table Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 0a1a9d0) Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com>
AlexRuiz7
changed the title
Add error management to actions of the Rules/Decoders/CDB Lists' tables
Fix Rules/Decoders/CDB lists uploader to show error appropriately
Jul 15, 2022
AlexRuiz7
changed the title
Fix Rules/Decoders/CDB lists uploader to show error appropriately
Fix Rules/Decoders/CDB lists uploader to show errors appropriately
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds error management to the action buttons of Rules/Decoders/CDB Lists' tables.
If there is some error in the action button, a toast should be displayed with the error.
Closes #4288.
Screenshots
Related to: #4288
Tests