TypeError resolved

[chantal-kelm]

Research

In public/plugin.ts a Get request is done with a Kibana resource core.http.get(/api/check-wazuh).

That resource fails in Chrome and Firefox browsers.

The Kibana core get resource is set up to catch the error with an HttpFetchError class that is a child of the Node Error class. Which is compatible only with browsers with V8 engine.
For this reason in Chrome it shows the error in the console as a debug and in Firefox it shows it in the console as an unrecognized error.

In the http_fetch_errors.ts and globals.d.ts files, kibana mentions V8 compatibility and that it will only work in browsers that use it. Attached screenshots
https://github.com/v8/v8/wiki/Stack%20Trace%20API#customizing-stack-traces

Proposed solution

Change the Get request that was made with a Kibana core.http.get(/api/check-wazuh) resource to the WzRequest.genericReq resource and it no longer fails, also add a test capture to public/plugin.ts that wraps the request and in case of failure, the error is detected when the browser does not work with the V8 engine.

Test

• Click on the hamburger menu
• Click on dashboard
• Click on home
• Click on Wazuh
• Check that the console does not show: TypeError: NetworkError when attempting to fetch resource

videofirefox.mp4

[AlexRuiz7]

This PR does not solve the problem. Take into account that is error might be a symptom of something else, like the App not being properly mounted / unmounted, not an isolated error.

Also, be thorough on the explanation on the cause of the problems and the work done to solve it.

In this case, incompatibilities with the V8 engine on Chrome and Firefox browsers are pointed as the cause of the error, but not a single reference supporting this theory is provided.

[Desvelao]

issue: the response variable doesn't have the endpoint response directly when using WzRequest.genericReq service, so it will not work as expected.

[chantal-kelm]

Fixed access to the isWazuhDisabled property and tested that it works by creating a user with a disabled role.

[AlexRuiz7]

• Code review: ✔️
• Test: ✔️

Note: check the changelog!

[Machi3mfl]

CR ✅
Test ✅

[github-actions]

Jest Test Coverage	%	values
Statements	6.84%	( 2493 / 36463 )
Branches	2.72%	( 768 / 28219 )
Functions	4.58%	( 408 / 8914 )
Lines	6.92%	( 2413 / 34888 )

[github-actions]

The backport to 4.3-7.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.3-7.16 4.3-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.3-7.16
# Create a new branch
git switch --create backport-4362-to-4.3-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 44a43cbe28cf92824da60627b38ff50800474e07
# Push it to GitHub
git push --set-upstream origin backport-4362-to-4.3-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.3-7.16

Then, create a pull request where the base branch is 4.3-7.16 and the compare/head branch is backport-4362-to-4.3-7.16.

[github-actions]

The backport to 4.3-1.2-wzd failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.3-1.2-wzd 4.3-1.2-wzd
# Navigate to the new working tree
cd .worktrees/backport-4.3-1.2-wzd
# Create a new branch
git switch --create backport-4362-to-4.3-1.2-wzd
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 44a43cbe28cf92824da60627b38ff50800474e07
# Push it to GitHub
git push --set-upstream origin backport-4362-to-4.3-1.2-wzd
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.3-1.2-wzd

Then, create a pull request where the base branch is 4.3-1.2-wzd and the compare/head branch is backport-4362-to-4.3-1.2-wzd.