-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize Wazuh plugin with custom logos #4539
Initialize Wazuh plugin with custom logos #4539
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR : LGTM ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review: 🔴
Check suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.16 4.4-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.16
# Create a new branch
git switch --create backport-4539-to-4.4-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b9f7cf3cc4d4a24bfc4f8995a8096226533dfad1
# Push it to GitHub
git push --set-upstream origin backport-4539-to-4.4-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.16 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-1.2-wzd 4.4-1.2-wzd
# Navigate to the new working tree
cd .worktrees/backport-4.4-1.2-wzd
# Create a new branch
git switch --create backport-4539-to-4.4-1.2-wzd
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b9f7cf3cc4d4a24bfc4f8995a8096226533dfad1
# Push it to GitHub
git push --set-upstream origin backport-4539-to-4.4-1.2-wzd
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-1.2-wzd Then, create a pull request where the |
* Create get-logos endpoint and initialize custom logos * Update endpoint name * Add Changelog Co-authored-by: Alex Ruiz Becerra <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit b9f7cf3)
* Create get-logos endpoint and initialize custom logos * Update endpoint name * Add Changelog Co-authored-by: Alex Ruiz Becerra <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit b9f7cf3) Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
* Create get-logos endpoint and initialize custom logos * Update endpoint name * Add Changelog Co-authored-by: Alex Ruiz Becerra <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit b9f7cf3)
* Create get-logos endpoint and initialize custom logos * Update endpoint name * Add Changelog Co-authored-by: Alex Ruiz Becerra <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit b9f7cf3) Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
Backports successfully merged |
Description
This PR fixes an issue when custom logos are configured, Wazuh default logos load first when the plugin initializes and afterwards the custom logos are loaded.
To fix this we created an endpoint to get the sidebar and the main custom logos configuration without the need to be authenticated. This endpoint is used just before the plugin initializes, so the proper logos are set up in the app mounting phase.
Closes #4538
Sample