-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos and errors code status replacement in wazuh-api controller #4728
Merged
asteriscos
merged 2 commits into
4.4-7.10
from
fix/wz-api-console-error-status-typos-4650
Oct 20, 2022
Merged
Fix typos and errors code status replacement in wazuh-api controller #4728
asteriscos
merged 2 commits into
4.4-7.10
from
fix/wz-api-console-error-status-typos-4650
Oct 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yenienserrano
approved these changes
Oct 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Machi3mfl
approved these changes
Oct 20, 2022
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.16 4.4-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.16
# Create a new branch
git switch --create backport-4728-to-4.4-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f6f437d4388ba2ccae2adfd00e82488294ea5220
# Push it to GitHub
git push --set-upstream origin backport-4728-to-4.4-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.16 Then, create a pull request where the |
asteriscos
added a commit
that referenced
this pull request
Oct 20, 2022
…azuh-api controller (#4733) * Replace generic HTTP status codes in the API controller (#4710) * Add http status codes constants * Replace internal server errors for service unavailable * Added changelog and made the error constant an enum * Add HTTP status unit test * Update CHANGELOG.md Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 9f53850) * Fix typos and errors code status replacement in wazuh-api controller (#4728) * Fix typos and replacement errors * Add changelog (cherry picked from commit f6f437d) Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Team, this PR fixes typos and error codes that shouldn't be replaced in the pull request Replace generic HTTP status codes in the API controller #4710
Test
Check List
yarn test:jest