Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PDF header and footer input max row length #4805

Merged
merged 2 commits into from
Nov 3, 2022
Merged

Fix PDF header and footer input max row length #4805

merged 2 commits into from
Nov 3, 2022

Conversation

asteriscos
Copy link
Member

Description

Hi team,
this PR increases the maximum character length of the header and footer PDF report customization.

Test

  • Go to Settings / Configuration
  • Customize a header and check the maximum character length is 40
  • Customize a footer and check the maximum character length is 50

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos requested a review from Tostti November 3, 2022 17:01
@asteriscos asteriscos requested a review from a team as a code owner November 3, 2022 17:01
@asteriscos asteriscos self-assigned this Nov 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

Code coverage (Jest) % values
Statements 8.52% ( 3137 / 36836 )
Branches 4.35% ( 1244 / 28616 )
Functions 7.41% ( 677 / 9137 )
Lines 8.58% ( 3026 / 35258 )

Mayons95
Mayons95 approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@Mayons95 Mayons95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TR: ✔️
LGTM

Test Details

Screenshot from 2022-11-03 14-32-57

Screenshot from 2022-11-03 14-33-08

Tostti
Tostti approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asteriscos asteriscos merged commit 70ac3c9 into 4.4-7.10 Nov 3, 2022
@asteriscos asteriscos deleted the fix/pdf-header-footer-textarea-max-row-length branch November 3, 2022 17:40
@github-actions github-actions bot mentioned this pull request Nov 3, 2022
Merged
github-actions bot pushed a commit that referenced this pull request Nov 3, 2022
@asteriscos @github-actions
Fix PDF header and footer input max row length (#4805)
79a3c75 
* Increase PDF header footer textarea max row length

* Added changelog

(cherry picked from commit 70ac3c9)
github-actions bot pushed a commit that referenced this pull request Nov 3, 2022
@asteriscos @github-actions
Fix PDF header and footer input max row length (#4805)
a3932f2 
* Increase PDF header footer textarea max row length

* Added changelog

(cherry picked from commit 70ac3c9)
@github-actions github-actions bot mentioned this pull request Nov 3, 2022
Merged
asteriscos added a commit that referenced this pull request Nov 3, 2022
@github-actions @asteriscos
[Backport 4.4-7.16] Fix PDF header and footer input max row length (#…
de58f90 
…4806)

Fix PDF header and footer input max row length (#4805)

* Increase PDF header footer textarea max row length

* Added changelog

(cherry picked from commit 70ac3c9)

Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
asteriscos added a commit that referenced this pull request Nov 3, 2022
@github-actions @asteriscos
[Backport 4.4-2.3-wzd] Fix PDF header and footer input max row length (…
c8cf07b 
…#4807)

Fix PDF header and footer input max row length (#4805)

* Increase PDF header footer textarea max row length

* Added changelog

(cherry picked from commit 70ac3c9)

Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
@Desvelao Desvelao mentioned this pull request Dec 20, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mayons95 Mayons95 Mayons95 approved these changes

@Tostti Tostti Tostti approved these changes

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asteriscos @Tostti @Mayons95