Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix architecture link in the deploy agent wizard #4876

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

chantal-kelm
Copy link
Member

@chantal-kelm chantal-kelm commented Nov 16, 2022

Description

Raspbian OS, Ubuntu, Amazon Linux and Amazon Linux 2 commands in the wizard deploy agent now change when selecting a different architecture.

Issues Resolved

[#4204]

Evidence

Grabacion.de.pantalla.2022-11-16.a.la.s.14.43.45.mov

Steps to test:

*Go to the Agents tab
*Click on the 'Deploy new agent' button.
*Verify that when changing architecture the OS Raspbian, Ubuntu, Amazon Linux and Amazon Linux 2 show the commands according to the selected architecture.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@chantal-kelm chantal-kelm requested a review from a team as a code owner November 16, 2022 17:53
@chantal-kelm chantal-kelm self-assigned this Nov 16, 2022
@chantal-kelm chantal-kelm linked an issue Nov 16, 2022 that may be closed by this pull request
@chantal-kelm chantal-kelm changed the title link of architecture Fix link of architecture Nov 16, 2022
@chantal-kelm chantal-kelm changed the title Fix link of architecture Fix architecture link in the deploy agent wizard Nov 16, 2022
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.68% ( 3209 / 36955 )
Branches 4.43% ( 1271 / 28683 )
Functions 7.59% ( 696 / 9165 )
Lines 8.75% ( 3096 / 35375 )

@Mayons95 Mayons95 self-requested a review November 16, 2022 19:02
Copy link
Contributor

@Mayons95 Mayons95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TR: ✔️

@chantal-kelm chantal-kelm merged commit 6bc39ca into 4.4-7.10 Nov 16, 2022
@chantal-kelm chantal-kelm deleted the fix-link-of-architecture branch November 16, 2022 19:05
@github-actions
Copy link
Contributor

The backport to 4.4-7.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.16 4.4-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.16
# Create a new branch
git switch --create backport-4876-to-4.4-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6bc39ca12a6151488c83baf70ff26c57c1b6b60b
# Push it to GitHub
git push --set-upstream origin backport-4876-to-4.4-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.16

Then, create a pull request where the base branch is 4.4-7.16 and the compare/head branch is backport-4876-to-4.4-7.16.

github-actions bot pushed a commit that referenced this pull request Nov 16, 2022
* link of architecture

* CHANGELOG

(cherry picked from commit 6bc39ca)
chantal-kelm added a commit that referenced this pull request Nov 17, 2022
…rd (#4877)

Fix architecture link in the deploy agent wizard (#4876)

* link of architecture

* CHANGELOG

(cherry picked from commit 6bc39ca)

Co-authored-by: Chantal Belén kelm <99441266+chantal-kelm@users.noreply.github.com>
@chantal-kelm chantal-kelm restored the fix-link-of-architecture branch November 17, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update agent installation command for all agents
3 participants